Skip to content

django >=2.2, <=3.1 (drops 1.11) #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

django >=2.2, <=3.1 (drops 1.11) #823

wants to merge 1 commit into from

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Sep 3, 2020 •
edited
Loading

Fixes #822, #803

Description of the Change

Remove Django 1.11 from and add Django 3.1 to test matrix, setup.py

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk requested a review from sliverc September 3, 2020 17:44
@n2ygk
Copy link
Contributor Author

n2ygk commented Sep 3, 2020

ugh, forgot that .travis.yml separately lists the environents.

@n2ygk n2ygk force-pushed the issue822/django31 branch from 227c96b to 9b74e1c Compare September 3, 2020 17:50
@codecov
Copy link

codecov bot commented Sep 3, 2020 •
edited
Loading

Codecov Report

Merging #823 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   97.08%   97.08%           
=======================================
  Files          58       58           
  Lines        3158     3158           
=======================================
  Hits         3066     3066           
  Misses         92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7458d56...dc8adfa. Read the comment docs.

@sliverc
Copy link
Member

sliverc commented Sep 3, 2020

Thanks for looking out for this. I think we should wait with this PR though as DRF 3.11 is not officially supporting Django 3.1. Also locally on my machine the tests are failing with DRF 3.11 and Django 3.1. Reason seems that the setup.py is not updated yet in terms of Django range and Travis actually doesn't install Django 3.1 but still 3.0.

See for example this job

@n2ygk n2ygk force-pushed the issue822/django31 branch from 9b74e1c to dc8adfa Compare September 4, 2020 13:04
@n2ygk
Copy link
Contributor Author

n2ygk commented Sep 4, 2020

OK, I've updated setup.py to add py38, and django<3.2. Let's see if that at least fixes the travis job.

@n2ygk n2ygk marked this pull request as draft September 4, 2020 13:12
@n2ygk
Copy link
Contributor Author

n2ygk commented Sep 4, 2020

@sliverc FYI - I've opened encode/django-rest-framework#7518 as it does appear that Django 3.1 is supported as of DRF 3.11.1 but the documentation is lagging.

@n2ygk n2ygk added this to the 3.3.0 milestone Sep 18, 2020
@n2ygk n2ygk changed the title add django 3.1 to test matrix django >=2.0, <=3.1 (drops 1.11) Sep 18, 2020
@n2ygk n2ygk changed the title django >=2.0, <=3.1 (drops 1.11) django >=2.1, <=3.1 (drops 1.11) Sep 18, 2020
@sliverc sliverc mentioned this pull request Sep 21, 2020
Merged
5 tasks
@n2ygk n2ygk changed the title django >=2.1, <=3.1 (drops 1.11) django >=2.2, <=3.1 (drops 1.11) Sep 29, 2020
@sliverc
Copy link
Member

sliverc commented Oct 5, 2020

It was quicker to create a new PR #835 instead of updating this. Superseded therefore.

@sliverc sliverc closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliverc sliverc Awaiting requested review from sliverc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

add Django 3.1
2 participants
@n2ygk @sliverc